[PATCH] D59520: [WebAssembly] Address review comments on r352930

[Dan Gohman via Phabricator via cfe-commits]

sunfish updated this revision to Diff 197215.
sunfish added a comment.

Implemented proper diagnostics for import_name/import_module on functions with definitions, and updated the test.

I'm unsure of the `DIAG_SIZE_SEMA` change, but without it, the build fails with this error:

  /llvm/tools/clang/lib/Basic/DiagnosticIDs.cpp:72:3: error: static assertion failed: DIAG_SIZE_SEMA is insufficient to contain all diagnostics, it may need to be made larger in DiagnosticIDs.h.
     static_assert(                                                               \
     ^
  /llvm/tools/clang/lib/Basic/DiagnosticIDs.cpp:88:1: note: in expansion of macro ‘VALIDATE_DIAG_SIZE’
   VALIDATE_DIAG_SIZE(SEMA)
   ^~~~~~~~~~~~~~~~~~


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59520/new/

https://reviews.llvm.org/D59520

Files:
  include/clang/Basic/DiagnosticIDs.h
  include/clang/Basic/DiagnosticSemaKinds.td
  include/clang/Sema/Sema.h
  lib/Sema/SemaDecl.cpp
  lib/Sema/SemaDeclAttr.cpp
  test/Sema/attr-wasm.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59520.197215.patch
Type: text/x-patch
Size: 8552 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190429/a178311c/attachment.bin>