[PATCH] D60974: Clang IFSO driver action.

[Jake Ehrlich via Phabricator via cfe-commits]

jakehehrlich added inline comments.


================
Comment at: clang/include/clang/Driver/Types.def:91
 TYPE("ast",                      AST,          INVALID,         "ast",   "u")
+TYPE("ifso",                     IFSO,         INVALID,         "ifso",  "u")
 TYPE("pcm",                      ModuleFile,   INVALID,         "pcm",   "u")
----------------
I think a different name should be used for a few reasons

1) ifso is the name of a tool used internally at Google that isn't anything like this. I'd like to avoid confusion or anything related.
2) .tbe is the format name for the textual fully linked format in llvm and I feel like we should hearken back to this but this isn't critical really.
3) the end is "so" but this is the intermediate format should it should not have the "so".

I think ".tbo" or ".tbe.o" or something like that would be my preferred sort of name. This is also in holding with ".tbd" which is the text based version of ".dnylib" on MacOSX. so it's generally consistent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60974/new/

https://reviews.llvm.org/D60974