[PATCH] D61175: [MinGW] Don't let template instantiation declarations cover nested classes
Reid Kleckner via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Apr 29 14:03:30 PDT 2019
rnk added inline comments.
================
Comment at: lib/Sema/SemaTemplateInstantiate.cpp:2687-2689
if ((Context.getTargetInfo().getCXXABI().isMicrosoft() ||
- Context.getTargetInfo().getTriple().isWindowsItaniumEnvironment()) &&
+ Context.getTargetInfo().getTriple().isWindowsItaniumEnvironment() ||
+ Context.getTargetInfo().getTriple().isWindowsGNUEnvironment()) &&
----------------
I think this can be simplified to "if Windows" at this point. But, I'm confused why we need this change to the general template instantiation machinery... Anyway, I'll send the simplification as a code review.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61175/new/
https://reviews.llvm.org/D61175
More information about the cfe-commits
mailing list