[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns
Richard Townsend (Arm) via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Apr 29 08:39:44 PDT 2019
richard.townsend.arm added inline comments.
================
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1080
+ if (const auto *Constructor = dyn_cast<CXXConstructorDecl>(RD))
+ if (Constructor->isUserProvided())
+ return true;
----------------
So I think that the problem with this new check is that it doesn't check all of the constructors. I replaced it with
for (auto it = RD->ctor_begin(); it != RD->ctor_end(); ++it) {
if (it->isUserProvided())
return true;
}
And that seems to resolve the `setw` problem.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60349/new/
https://reviews.llvm.org/D60349
More information about the cfe-commits
mailing list