[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

Mon Apr 29 05:45:07 PDT 2019

whisperity added a comment.

I think this is good. Patch still marked as //Needs review// for some reason. 😦 Can we look up this `blocking review` thing? Perhaps this could be marked ready to roll once the dependency patch is ironed out.

================
Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:332
+  AnOpts.Config.insert({(Twine() + CheckerFullName + ":" + OptionName).str(),
+                        DefaultValStr});
 }
----------------
baloghadamsoftware wrote:
> `Twine(CheckerFullName) + ":" + OptionName`. However, since the constructor `Twine(const StringRef &Str)` is implicit, `CheckerFullName + ":" + OptionName` results the same and is more readable.
This comment is **Done**.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57922/new/

https://reviews.llvm.org/D57922