[PATCH] D61051: [analyzer] Treat functions without runtime branches as "small".
Csaba Dabis via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Apr 28 22:54:58 PDT 2019
Charusso accepted this revision.
Charusso added a comment.
This revision is now accepted and ready to land.
Great patch! There is only a design problem:
You have negated every `isSmall()` condition looks like you could write `isLarge()` instead but there is no connection between these functions.
Could you rename or redesign them? The following would be cool: `isLarge()` iff `!isSmalll` and `isSmall()` iff `!isLarge()`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61051/new/
https://reviews.llvm.org/D61051
More information about the cfe-commits
mailing list