[PATCH] D61209: Fix readability-redundant-smartptr-get for MSVC STL

Florian Gross via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 26 12:34:03 PDT 2019


fgross created this revision.
fgross added reviewers: aaron.ballman, alexfh, sbenza.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

The MSVC STL defines smart pointer `operator*` and `operator->` as method templates. The existing duck typing implementation doesn't catch this implementation. To keep the duck typing simple, I added the already existing list of known standard to the matchers in `registerMatchersForGetArrowStart`.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D61209

Files:
  clang-tools-extra/clang-tidy/readability/RedundantSmartptrGetCheck.cpp
  clang-tools-extra/test/clang-tidy/readability-redundant-smartptr-get-msvc.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61209.196898.patch
Type: text/x-patch
Size: 6277 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190426/01d74556/attachment-0001.bin>


More information about the cfe-commits mailing list