[PATCH] D61194: [HIP] Fix visibility of `constant` variables.

Fri Apr 26 11:41:24 PDT 2019

hliao marked an inline comment as done.
hliao added inline comments.

================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:7851
+         (isa<VarDecl>(D) &&
+          (D->hasAttr<CUDADeviceAttr>() || D->hasAttr<CUDAConstantAttr>()));
 }
----------------
yaxunl wrote:
> is format right?
yeah, it's the format after clang-format. It seems that clang-format try to apply the same indent for LHS & RHS of a binary operator. With the leading parenthesis, RHS in a newline is indented with one more space.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61194/new/

https://reviews.llvm.org/D61194

[PATCH] D61194: [HIP] Fix visibility of `__constant__` variables.

[PATCH] D61194: [HIP] Fix visibility of `constant` variables.