[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

Paul Robinson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 26 08:32:47 PDT 2019


probinson added a comment.

I had tried to do this in r333311 but some bots complained, so I reverted it and then didn't follow through.  Thanks for doing this!
When I tried it, I took advantage of existing tracking of line directives at the file level, so there shouldn't be a need to add a Line flag to PresumedLoc?
What I did was something like this, in computeChecksum():

  const SrcMgr::SLocEntry &Entry = SM.getSLocEntry(FID, &Invalid);
  if (Invalid || !Entry.isFile() || Entry.getFile().hasLineDirectives())
    return None;


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60283/new/

https://reviews.llvm.org/D60283





More information about the cfe-commits mailing list