[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 25 18:57:08 PDT 2019


efriedma added inline comments.


================
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1078
+    return true;
+  if (RD->hasUserDeclaredConstructor())
+    return true;
----------------
Like I mentioned before, the rule says "user-provided", not "user-declared".


================
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1080
+    return true;
+  if (RD->hasUserDeclaredDestructor())
+    return true;
----------------
The rule says "trivial" not "user-declared".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60349/new/

https://reviews.llvm.org/D60349





More information about the cfe-commits mailing list