[PATCH] D61140: Copy Argument Passing Restrictions setting when importing a CXXRecordDecl definition

Aleksei Sidorin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 25 15:45:37 PDT 2019


a_sidorin added a comment.

Hello Shafik!
The patch itself is fine, but, as other reviewers pointed, tests are appreciated. I suggest to add a test into ASTImporterTests.cpp - you will find several ways to write tests of different complexity here. I think this change can be tested even with the simplest testImport() facility.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61140/new/

https://reviews.llvm.org/D61140





More information about the cfe-commits mailing list