[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

[Richard Townsend (Arm) via Phabricator via cfe-commits]

richard.townsend.arm added inline comments.


================
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1074
+  if (!RD->hasTrivialCopyAssignment())
+    return true;
+  return false;
----------------
richard.townsend.arm wrote:
> Should this function also check for user-provided constructors?
I think it should: I speculatively added these two lines

  if (RD->hasUserDeclaredConstructor())
    return true;

and it resolved the problem with `std::setw` I mentioned in the bug tracker (which means Electron could start). 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60349/new/

https://reviews.llvm.org/D60349