[PATCH] D61015: [LibTooing] Change Transformer's TextGenerator to a partial function.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 25 05:37:40 PDT 2019


ilya-biryukov added a comment.

Why would we consider this a legitimate failure, rather than a programming error?
Same argument could be made about any form of format-string-like functions, e.g. `llvm::formatv` or `sprintf`.
Yet, they return strings and not `Expected<string>` or their equivalent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61015/new/

https://reviews.llvm.org/D61015





More information about the cfe-commits mailing list