[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 25 05:27:31 PDT 2019


martong added a comment.

In D60934#1475908 <https://reviews.llvm.org/D60934#1475908>, @Tyker wrote:

> Fixed issues form feedback by @martong


Thank you for addressing the comments. `ASTImporter.cpp` and `ASTStructuralEquivalence.cpp` looks good to me now. However, about the equivalence check, do you think it would be possible to have a unit test for explicit(bool) in `StructuralEquivalenceTest.cpp`? That test would exercise the static `EquivalentExplicit()` function too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60934/new/

https://reviews.llvm.org/D60934





More information about the cfe-commits mailing list