[PATCH] D60967: Move setTargetAttributes after setGVProperties in SetFunctionAttributes

Scott Linder via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 24 12:49:19 PDT 2019


scott.linder added a comment.

@rjmccall Would you expect similar conflicts in explicit visibility to result in diagnostics? For example, marking a `static` variable with an explicit visibility attribute doesn't warn, instead the explicit visibility attribute is silently ignored. GCC 7.3 complains with `warning: ‘__visibility__’ attribute ignored [-Wattributes]`


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60967/new/

https://reviews.llvm.org/D60967





More information about the cfe-commits mailing list