[PATCH] D61040: [Fuchsia] Support multilib for -fsanitize=address and -fno-exceptions

[Jonathan Roelofs via Phabricator via cfe-commits]

jroelofs added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:122
+
+/// \p Flag must be a flag accepted by the driver with its leading '-' removed,
+//     otherwise '-print-multi-lib' will not emit them correctly.
----------------
Can we enforce this precondition with an assert? The '-'-prefix-not-there part is easy, but what about the "it's a driver flag" part?


================
Comment at: clang/test/Driver/fuchsia.cpp:53
+
+// RUN: %clang %s -### --target=x86_64-fuchsia -fno-exceptions \
+// RUN:     -resource-dir=%S/Inputs/resource_dir_with_per_target_subdir \
----------------
What about a test for `-fsanitize=address` + `-fno-exceptions`?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61040/new/

https://reviews.llvm.org/D61040