[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 23 16:05:07 PDT 2019


alexfh added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/rename_check.py:271
+    new_namespace = new_module
+  if old_module != new_module or new_namespace == 'llvm_check':
     check_implementation_files = glob.glob(
----------------
Why `new_namespace == 'llvm_check'` is needed? Can we figure out old_namespace and use the condition `new_namespace != old_namespace` instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60629/new/

https://reviews.llvm.org/D60629





More information about the cfe-commits mailing list