[PATCH] D60995: [clangd] Make sure include path does not contain any backslashes on Windows

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 23 00:19:40 PDT 2019


kadircet added a comment.

I had just looked at the method name and thought it was the right place( `suggestPathToFileForDiagnostics` since it says "path to file".)

But looking at the comments,

  /// Suggest a path by which the specified file could be found, for
  /// use in diagnostics to suggest a #include.

HeaderSearch API itself seems like a better place, I suppose the confusion comes from the fact that paths and the include-directives are
the same on unix-like systems.

Updating the patch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60995/new/

https://reviews.llvm.org/D60995





More information about the cfe-commits mailing list