[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.
Roman Lebedev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 23 00:11:29 PDT 2019
lebedev.ri added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/linuxkernel/MustCheckErrsCheck.cpp:12
+#include "clang/ASTMatchers/ASTMatchFinder.h"
+#include <c++/8/bits/c++config.h>
+
----------------
This looks wrong
================
Comment at: clang-tools-extra/clang-tidy/linuxkernel/MustCheckErrsCheck.cpp:24
+ "ERR_CAST", "PTR_ERR_OR_ZERO"));
+ auto NonCheckingStmts = stmt(anyOf(compoundStmt(), labelStmt()));
+ Finder->addMatcher(
----------------
Are there any rules what kernel considers to be checking and not checking?
This i think e.g. will accept cast-to-void, assignment to a variable and then ignoring it, etc.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59963/new/
https://reviews.llvm.org/D59963
More information about the cfe-commits
mailing list