[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

[Eli Friedman via Phabricator via cfe-commits]

efriedma added inline comments.


================
Comment at: lib/Sema/SemaDeclCXX.cpp:5906
+    bool isAArch64 = S.Context.getTargetInfo().getTriple().isAArch64();
+    if (isAArch64 && !D->isAggregate())
+      return false;
----------------
The isAggregate predicate is not appropriate to check here; it varies depending on whether the language version is C++14 or C++17.  For example, C++17 aggregates are allowed to have base classes.  You have to split out checking the relevant properties (getNumBases(), isDynamicClass(), etc.).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60349/new/

https://reviews.llvm.org/D60349