[PATCH] D60748: Fix i386 struct and union parameter alignment

[Reid Kleckner via Phabricator via cfe-commits]

rnk added a comment.

This is, obviously, an ABI break. I think Sony would probably want you to preserve the existing behavior of intentionally underaligning such byval parameters for PS4 targets. + at rjmccall in case he has other ABI thoughts.



================
Comment at: lib/CodeGen/TargetInfo.cpp:1496
+  if (IsDarwinVectorABI) {
+    // On Darwin, if the type contains an SSE vector type, the alignment is 16.
+    if (Align >= 16 && (isSSEVectorType(getContext(), Ty) ||
----------------
@rjmccall, does this comment need updating in an AVX world?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60748/new/

https://reviews.llvm.org/D60748