[PATCH] D60873: [clang][HeaderSuggestion] Handle the case of dotdot with an absolute path

Matthew Voss via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 18 11:41:55 PDT 2019


ormris added inline comments.


================
Comment at: clang-tools-extra/unittests/clangd/HeadersTests.cpp:220
+  BarHeader = testPath("sub/bar.h");
+  EXPECT_EQ(calculate(BarHeader), "\"sub/bar.h\"");
 }
----------------
Quick nit: This test won't work on Windows as it only tests for POSIX-style path separators. You could easily add a Windows ifdef, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60873/new/

https://reviews.llvm.org/D60873





More information about the cfe-commits mailing list