[PATCH] D60827: [rename] Deduplicate symbol occurrences

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 18 07:44:40 PDT 2019


hokein marked an inline comment as done.
hokein added inline comments.


================
Comment at: clang-tools-extra/unittests/clangd/ClangdTests.cpp:1160
 
+TEST_F(ClangdVFSTest, NoDuplicatedTextEditsOnRename) {
+  MockFSProvider FS;
----------------
kadircet wrote:
> maybe put the test under clang/unittests/Rename?
I considered it before, but it is not trivial to add the test there unfortunately :( I'd keep the test as-is. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60827/new/

https://reviews.llvm.org/D60827





More information about the cfe-commits mailing list