[PATCH] D60267: [clangd] Support relatedInformation in diagnostics.

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added inline comments.


================
Comment at: clangd/Diagnostics.cpp:271
+      if (!Note.AbsFile) {
+        log("Dropping note from unknown file: {0}", Note);
+        continue;
----------------
ilya-biryukov wrote:
> Maybe `vlog`? This is what we use for dropped diagnostics, should probably stick to the same level with dropped notes (even though the dropped notes probably come up less often in practice).
We seem to be dropping these only at related information case, what about flattening?
Maybe we should get rid of them at that stage as well.


================
Comment at: clangd/Diagnostics.cpp:417
     D.InsideMainFile = InsideMainFile;
     D.File = Info.getSourceManager().getFilename(Info.getLocation());
+    auto &SM = Info.getSourceManager();
----------------
Do we still need the File field as well?


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60267/new/

https://reviews.llvm.org/D60267