[PATCH] D60736: [Sema][ObjC] Don't warn about a block implicitly retaining self if the block is marked noescape

Erik Pilkington via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 17 15:27:15 PDT 2019


erik.pilkington accepted this revision.
erik.pilkington added a comment.

LGTM too, thanks!



================
Comment at: lib/Sema/SemaDecl.cpp:13169
+    do {
+      R = R || !CurBD->doesNotEscape();
+      if (R)
----------------
This can just be R = !CurBD->doesNotEscape();


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60736/new/

https://reviews.llvm.org/D60736





More information about the cfe-commits mailing list