[PATCH] D60808: [analyzer] pr41335: NoStoreFuncVisitor: Fix crash when no-store event is in a body-farmed function.

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.

LG with a couple of nits.



================
Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:582
+    if (!L.hasValidLocation()) {
+      // Do we need to suppress our report for body-farmed functions as well?
+      // Or maybe attach the note to the call site instead?
----------------
Should this be marked with a FIXME?


================
Comment at: clang/test/Analysis/diagnostics/body-farm-crashes.c:1
+// RUN: %clang_analyze_cc1 -w -analyzer-checker=core\
+// RUN:                    -analyzer-output=text -verify %s
----------------
Add a space before the backslash.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60808/new/

https://reviews.llvm.org/D60808