[PATCH] D60736: [Sema][ObjC] Don't warn about a block implicitly retaining self if the block is marked noescape

Erik Pilkington via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 17 11:09:33 PDT 2019


erik.pilkington added inline comments.


================
Comment at: lib/Parse/ParseObjc.cpp:3696-3699
+
+  Actions.ActOnEndOfObjCMethodDef();
+
   // Clean up the remaining EOF token.
----------------
Any reason not to do this check in `ActOnFinishFunctionBody` (which is called by ParseFunctionStatementBody)? Seems like there are some similar diagnostics implemented there.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60736/new/

https://reviews.llvm.org/D60736





More information about the cfe-commits mailing list