[PATCH] D60728: [clang] [test] Add a (xfailing) test for PR41027

Kamil Rytarowski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 17 10:34:04 PDT 2019


krytarowski added a comment.

In D60728#1469794 <https://reviews.llvm.org/D60728#1469794>, @hans wrote:

> In D60728#1468713 <https://reviews.llvm.org/D60728#1468713>, @krytarowski wrote:
>
> > In D60728#1468486 <https://reviews.llvm.org/D60728#1468486>, @hans wrote:
> >
> > > What's the value in checking in this xfail'ed test without an actual fix for the problem?
> >
> >
> > Raise awareness about the problem.
>
>
> I don't think that works. No one is reading through the test files of the repository.


Well, I think we should treat it from the other side around.

Could we please revert it and backport revert to 8.0.1? The author(s) can improve the implementation and get this pr41027 test to check if a new version works.

Right now this blocks upgrades on NetBSD as a number of CPUs is affected (but not x86, so it was overlooked before 8.0 by others than @joerg).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60728/new/

https://reviews.llvm.org/D60728





More information about the cfe-commits mailing list