[PATCH] D58033: Add option for emitting dbg info for call sites

Wed Apr 17 07:32:25 PDT 2019

djtodoro marked 2 inline comments as done.
djtodoro added a comment.

@probinson @aprantl Thanks a lot for your comments!

Let's clarify some things. I'm sorry about the confusion.

Initial patch for the functionality can be restricted by this option (like we pushed here), since **LLDB** doesn't read this type of debug info (yet).
The plan is, when  **LLDB** has all necessary info and we are sure that everything works fine during using this info in debugging sessions, we can turn it to `ON` by default.

Does that make sense ? :)

================
Comment at: include/clang/Driver/Options.td:921
+                       Group<f_clang_Group>,
+                       Flags<[CC1Option]>,
+                       HelpText<"Enables debug info about call site and call site parameters">;
----------------
probinson wrote:
> I believe that by marking this with `[CC1Option]` cc1 will automatically understand it and you won't need to define a separate option in CC1Options.td.
I can't remember what problem we occurred with this on 4.0, but we definitely don't need both definitions.
Thanks for this!  

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58033/new/

https://reviews.llvm.org/D58033