[PATCH] D60736: [Sema][ObjC] Don't warn about a block implicitly retaining self if the block is marked noescape
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 16 20:41:35 PDT 2019
rjmccall added inline comments.
================
Comment at: lib/Sema/SemaExpr.cpp:2580
+ if (const BlockDecl *BD = CurContext->getInnerMostBlockDecl())
+ if (!getDiagnostics().isIgnored(diag::warn_implicitly_retains_self, Loc))
+ ImplicitlyRetainedSelfLocs.push_back({Loc, BD});
----------------
IIRC this check can be expensive enough that it's probably not worth doing if you expect these entries to typically not result in diagnostics.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60736/new/
https://reviews.llvm.org/D60736
More information about the cfe-commits
mailing list