[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'
Alexander Kornienko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 16 13:35:39 PDT 2019
alexfh added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/add_new_check.py:381
+ # Don't allow 'clang' or 'llvm' namespaces
+ if module == 'llvm' or module == 'clang':
+ namespace = module + '_check'
----------------
We don't have the `clang` module. No need to check for it here. If we ever add one (which I doubt), we can modify this script again. But for now let's remove this to avoid confusion.
================
Comment at: clang-tools-extra/clang-tidy/rename_check.py:268
+ if old_module != new_module or new_module == 'llvm' or new_module == 'clang':
+ if new_module == 'llvm' or new_module -- 'clang':
+ new_namespace = new_module + '_check'
----------------
`--`?
Anyways, we don't have (or plan to have) a module named `clang`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60629/new/
https://reviews.llvm.org/D60629
More information about the cfe-commits
mailing list