[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

Djordje Todorovic via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 16 05:42:10 PDT 2019


djtodoro marked 3 inline comments as done.
djtodoro added inline comments.


================
Comment at: lib/CodeGen/CGDebugInfo.cpp:4537
+      CGM.getLangOpts().Optimize) {
+    for (auto &SP : DeclCache) {
+      auto *D = SP.first;
----------------
aprantl wrote:
> Just looking at the type declarations in CGDebugInfo.h: Why not iterate over the `SPCache`  directly? Shouldn't that contain all Function declarations only?
I tried it, but `SPCache` is empty at this point.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58035/new/

https://reviews.llvm.org/D58035





More information about the cfe-commits mailing list