[PATCH] D60735: [FileSystemStatCache] Return std::error_code from stat cache methods

[Harlan Haskins via Phabricator via cfe-commits]

harlanhaskins created this revision.
harlanhaskins added a reviewer: benlangmuir.
Herald added subscribers: cfe-commits, dexonsmith.
Herald added a project: clang.

Previously, we would return true/false signifying if the cache/lookup
succeeded or failed. Instead, provide clients with the underlying error
that was thrown while attempting to look up in the cache.

Since clang::FileManager doesn't make use of this information, it discards the
error that's received and casts away to bool.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D60735

Files:
  clang/include/clang/Basic/FileSystemStatCache.h
  clang/lib/Basic/FileManager.cpp
  clang/lib/Basic/FileSystemStatCache.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60735.195264.patch
Type: text/x-patch
Size: 7559 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190415/610856f9/attachment.bin>