[PATCH] D59919: [Attributor] Deduce "returned" argument attribute

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 15 10:11:30 PDT 2019


jdoerfert marked an inline comment as done.
jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:495
+  virtual size_t getNumReturnValues() const override {
+    return isValidState() ? ReturnedValues.size() : -1;
+  }
----------------
This should probably call `llvm_unreachable` with a message instead of returning -1.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59919/new/

https://reviews.llvm.org/D59919





More information about the cfe-commits mailing list