[PATCH] D59673: [Driver] Allow setting the DWO name DWARF attribute separately

Sun Apr 14 18:30:21 PDT 2019

aaronpuchert planned changes to this revision.
aaronpuchert added a comment.

In D59673#1461983 <https://reviews.llvm.org/D59673#1461983>, @dblaikie wrote:

> Sure, I think the naming's a bit weird (but hard to come up with good names for any of this)

Agreed, `-split-dwarf-output` is pretty clear, but `-split-dwarf-file` could be both the actual filename or the attribute.

There is `test/CodeGen/split-debug-filename.c` checking that we emit `!DICompileUnit({{.*}}, splitDebugFilename: "foo.dwo"` into the IR under some circumstances, but I'm not sure why. It seems to be ignored by `llc`. What's the intended use for this? Your commit message in rC301063 <https://reviews.llvm.org/rC301063> suggests that this is needed for implicit modules. How does this work? I'm asking of course because I'm not sure whether we might need to emit both file names there.

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59673/new/

https://reviews.llvm.org/D59673