[PATCH] D53076: [analyzer] ConditionBRVisitor: Enhance to write out more information

[Csaba Dabis via Phabricator via cfe-commits]

Charusso updated this revision to Diff 195071.
Charusso marked 4 inline comments as done.
Charusso retitled this revision from "[analyzer] ConditionBRVisitor: enhance to write out more information" to "[analyzer] ConditionBRVisitor: Enhance to write out more information".
Charusso added a comment.

Address comments:

- Removed member variable.
- Introducing `PathDiagnosticPopUpPiece`(D60670 <https://reviews.llvm.org/D60670>)

Extras:

- Removed generic known condition evaluation printing
- So that we could not hook integers, removed that early-return code as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53076/new/

https://reviews.llvm.org/D53076

Files:
  clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h
  clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp
  clang/test/Analysis/Inputs/expected-plists/NewDelete-path-notes.cpp.plist
  clang/test/Analysis/Inputs/expected-plists/cxx-for-range.cpp.plist
  clang/test/Analysis/Inputs/expected-plists/edges-new.mm.plist
  clang/test/Analysis/Inputs/expected-plists/inline-plist.c.plist
  clang/test/Analysis/Inputs/expected-plists/objc-radar17039661.m.plist
  clang/test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist
  clang/test/Analysis/Inputs/expected-plists/plist-macros.cpp.plist
  clang/test/Analysis/Inputs/expected-plists/plist-output.m.plist
  clang/test/Analysis/Inputs/expected-plists/retain-release.m.objc.plist
  clang/test/Analysis/Inputs/expected-plists/retain-release.m.objcpp.plist
  clang/test/Analysis/NewDelete-path-notes.cpp
  clang/test/Analysis/diagnostics/no-store-func-path-notes.c
  clang/test/Analysis/diagnostics/no-store-func-path-notes.cpp
  clang/test/Analysis/diagnostics/no-store-func-path-notes.m
  clang/test/Analysis/inline-plist.c
  clang/test/Analysis/osobject-retain-release.cpp
  clang/test/Analysis/use-after-move.cpp
  clang/test/Analysis/virtualcall.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53076.195071.patch
Type: text/x-patch
Size: 127988 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190414/3c8f7220/attachment-0001.bin>