[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns
Eli Friedman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Apr 12 12:53:50 PDT 2019
efriedma added inline comments.
================
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1062
+ bool sretInX0 = (CGM.getTarget().getTriple().getArch() ==
+ llvm::Triple::aarch64) && !RD->isPOD();
+
----------------
ostannard wrote:
> This should also check aarch64_be.
aarch64_be-windows isn't a thing; it doesn't make sense to check for that explicitly.
That said, there is an isAArch64() helper which is probably more readable anyway.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60349/new/
https://reviews.llvm.org/D60349
More information about the cfe-commits
mailing list