[PATCH] D60561: [clang] fixing diagnostics of constexpr callstack

Fri Apr 12 11:41:15 PDT 2019

riccibruno added a comment.

In D60561#1464740 <https://reviews.llvm.org/D60561#1464740>, @Tyker wrote:

> @rsmith i don't think collecting theses values is expansive compared to evaluating the expression.
>  but i agree that we can disable the collection of these values when no diagnostics can be emited.

To help make an informed decision you can grab a big TU (I usually use `SemaDecl.cpp` or all of Boost) and then run `-fsyntax-only` on it. With a tool like `perf stat` you can get pretty good results.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60561/new/

https://reviews.llvm.org/D60561