[PATCH] D60257: [Lookup] Invisible decls should not be ambiguous when renaming.

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 12 04:53:38 PDT 2019


ioeric added inline comments.


================
Comment at: unittests/Tooling/LookupTest.cpp:215
+
+  // Potentially ambiguous symbols that are not visible at reference location
+  // are not considered ambiguous.
----------------
hokein wrote:
> The test seems hard to understand what it actually does, could you explain it? which symbol is ambiguous here? What's the behavior of the test before vs after the fix?
added comment. PTAL


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60257/new/

https://reviews.llvm.org/D60257





More information about the cfe-commits mailing list