[PATCH] D59640: [clangd] Add TemplateArgumentList into Symbol

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 12 01:42:18 PDT 2019


kadircet marked an inline comment as done.
kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:566
+        printTemplateSpecializationArgs(ND);
+    S.TemplateSpecializationArgs = TemplateSpecializationArgs;
     if (Opts.StoreAllDocumentation)
----------------
ilya-biryukov wrote:
> Any reason to not always fill in this field?
> 
It is simply because `printTemplateSpecializationArgs` should return an empty string in other cases. Since we mark all explicit specializations as *not* indexed for code completion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59640/new/

https://reviews.llvm.org/D59640





More information about the cfe-commits mailing list