[PATCH] D60561: [clang] fixing diagnostics of constexpr callstack

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith added a comment.

This seems liable to be moderately expensive, especially for large argument values, and it's a cost that is unnecessary in the common case where evaluation succeeds.

I wonder if we'd be better off speculatively trying the entire evaluation without storing any such values, and rerunning the evaluation to collect diagnostics only when we find that evaluation would fail (and we're in a context where the caller actually wants the diagnostics).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60561/new/

https://reviews.llvm.org/D60561