[PATCH] D60151: [clang-tidy] Rename llvm checkers to llvm-project

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 11 10:19:03 PDT 2019


lebedev.ri added a comment.

In D60151#1462976 <https://reviews.llvm.org/D60151#1462976>, @hintonda wrote:

> In D60151#1462850 <https://reviews.llvm.org/D60151#1462850>, @MyDeveloperDay wrote:
>
> > are we supporting "-llvm-*" in existing .clang-tidy files?
> >
> > If people selectively turn checkers off, won't all of a sudden everyone start getting llvm-project checks and fixes turned back on?
> >
> > https://github.com/search?q=-llvm-%2A&type=Code
> >
> > maybe we need to add something like:
> >
> >   llvm-header-guard (redirects to llvm-project-header-guard) <llvm-header-guard>
> >   llvm-header-include-order (redirects to llvm-project-include-order) <llvm-include-order>
> >   llvm-header-namespace-comment(redirects to llvm-project-namespace-comment) <llvm-namespace-comment>
> >   llvm-header-twine-local(redirects to llvm-project-twine-local) <llvm-twine-local>
> >  
> >
>
>
> I suppose we could keep the names and directory structure and just change the namespace.  That would just be a special case in the scripts.  Haven't looked into it yet, but will do so as soon as I can.


Isn't that matching done on strings? I.e. is there difference between `-llvm-*` and `-ll*` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60151/new/

https://reviews.llvm.org/D60151





More information about the cfe-commits mailing list