[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check
Eugene Zelenko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Apr 10 16:17:38 PDT 2019
Eugene.Zelenko added inline comments.
================
Comment at: clang-tidy/abseil/WrapUniqueCheck.cpp:85
+
+ std::string Left = (ConsDecl) ? "auto " + NameRef.str() + " = " : "";
+ std::string NewText =
----------------
I don't think that you need round brackets around ConsDecl. Same below.
================
Comment at: docs/clang-tidy/checks/abseil-wrap-unique.rst:5
+==================
+Looks for instances of factory functions which uses a non-public constructor
+that returns a ``std::unqiue_ptr<T>`` then recommends using ``absl::wrap_unique(new T(...))``.
----------------
Please separate with empty line.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57435/new/
https://reviews.llvm.org/D57435
More information about the cfe-commits
mailing list