[PATCH] D60503: [clangd] Don't insert extra namespace qualifiers when Sema gets lost.
Eric Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Apr 10 06:34:01 PDT 2019
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Feel free to land this. I'll rebase D60126 <https://reviews.llvm.org/D60126> on this when it's in.
================
Comment at: clangd/CodeComplete.cpp:580
+ // Case 3: sema saw and resolved a scope qualifier.
+ if (SemaSpecifier && SemaSpecifier->isValid())
+ return {Scopes.scopesForIndexQuery(), false};
----------------
nit: Sema Specifier can't be nullptr at this point.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60503/new/
https://reviews.llvm.org/D60503
More information about the cfe-commits
mailing list