[PATCH] D60161: Expose non-trivial struct helpers for Swift.
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 9 13:55:38 PDT 2019
rjmccall added a reviewer: ahatanak.
rjmccall added inline comments.
Herald added a subscriber: dexonsmith.
================
Comment at: clang/include/clang/CodeGen/CodeGenABITypes.h:140
+ QualType QT);
+
} // end namespace CodeGen
----------------
Would you mind calling these `get...` rather than `generate...`? It'd make it clearer that they will re-use an existing definition if possible.
Otherwise this looks great, thanks! Akira, any comments?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60161/new/
https://reviews.llvm.org/D60161
More information about the cfe-commits
mailing list