[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

Tue Apr 9 11:15:21 PDT 2019

thakis added a comment.

In D54187#1460181 <https://reviews.llvm.org/D54187#1460181>, @aprantl wrote:

> Did anyone take the time to look at dexter and whether it would fit the bill here? It would be great to avoid reimplementing its functionality just to have something that then only works on Windows.
>
> My position is that for the kind of very basic end-to-end testing that we do in this repository (set breakpoints+print variables), it should be possible to have one wrapper that supports multiple debuggers. I'm also fine with adding platform-specific tests into a subdirectory, but that should be the exception, not the rule. What I would like to avoid is growing a large parallel body of basic tests that only work on one platform.
>
> It sounded like dexter would be the missing glue layer that supports windows debuggers and unix debuggers alike. If that is feasible I would prefer to extend dexter to support WinDbg and migrating debuginfo-tests to use dexter over adding new code and more complexity to debuginfo-tests.

I just took a quick look. dexter is 7.3kLoC of python while this here is 50 lines. Dexter has code to talk to visual studio over COM (dex/debugger/visualstudio/windows/ComInterface.py etc) but doesn't have a way to call cdb. Visual Studio is a way bigger dependency than cdb.

$ cd ~/src
$ git clone https://github.com/SNSystems/dexter.git
$ cd dexter
$ find dex -name '*.py' -type f | xargs wc -l | grep total

  7382 total

thakis at thakis:~/src/dexter$ find dex -name '*.py' -type f | xargs grep cdb

nothing
=======

As zturner said above, we want explicit smoke testing for cdb. There's no desire to do all or even most of our debug info testing this way, but we'd like to have some integration tests for the debug engine we care about. dexter doesn't seem to help with this use case.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54187/new/

https://reviews.llvm.org/D54187