[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Tue Apr 9 06:17:30 PDT 2019

ABataev added a comment.

In D60455#1459678 <https://reviews.llvm.org/D60455#1459678>, @Fznamznon wrote:

> Hi all,
>
> I assume that something to mark the code which is supposed to be offloaded already is implemented for OpenMP and CUDA. For example I found CUDA-specific CUDADevice attribute.
>  I can't just use CUDA-specific attributes for SYCL but I think that these resources for marking device code could be unified and re-used for all supported single-source offload programming models (like SYCL, CUDA, OpenMP etc).
>  Please let me know If you have any suggestions about it.

The problem is that all thee attributes have different semantics. OpenMP-specific attributes, for example, cannot be specified explcitly as the attributes, because according to the standard they are represented as pragmas. Because of thatmost of the OpenMP attributes can be created only implicitly.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60455/new/

https://reviews.llvm.org/D60455