[PATCH] D60055: Check i < FD->getNumParams() before querying

Tue Apr 9 05:27:58 PDT 2019

Violet added a comment.

In D60055#1459602 <https://reviews.llvm.org/D60055#1459602>, @lebedev.ri wrote:

> I won't be able to properly review this, sorry.

Can you suggest someone with familiarity for this part of code? The reviewers I randomly added by `git blame` doesn't seem to be reviewing.

> While i'm sure this fix silences the assert, i don't know what that means for the original caller.
>  Does it fail? Does it retry in some other scope? Should it be more picky about the original scope in the first place?

This small function is just to get the canonical ParmValDecl for a given one. If the check doesn't pass, it simply mean there is no canonical one (it's obvious for a function pointer), so we just use the passed one. There is nothing wrong here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60055/new/

https://reviews.llvm.org/D60055