[PATCH] D59924: [PowerPC][Clang] Port MMX intrinsics and basic test cases to Power

[Chaofan Qiu via Phabricator via cfe-commits]

qiucf marked 2 inline comments as done.
qiucf added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/PPCLinux.cpp:22
+  if (getArch() != llvm::Triple::ppc &&
+      !DriverArgs.hasArg(clang::driver::options::OPT_nostdinc) &&
+      !DriverArgs.hasArg(options::OPT_nobuiltininc)) {
----------------
jsji wrote:
> Why we want to exclude these includes when `nostdinc` is on? These include files are NOT standard include files.
> `-nostdinc`: Do not search the standard system directories or compiler builtin directories for include files.
> From Clang's man page

And on Windows toolchain (MSVC.cpp), if turning on `-nostdinc`, Windows SDK files will also not be added into path.


================
Comment at: clang/test/Headers/ppc-intrinsics.c:7
+
+// RUN: NOT %clang -S -emit-llvm -target powerpc64-gnu-linux %s -o /dev/null 2>&1 | FileCheck %s -check-prefix=CHECK-ERROR
+
----------------
jsji wrote:
> NOT? 
> ` NOT: command not found ^`
It should be `not`, in downcase. This is what other test cases (see `test/CXX/temp/temp.spec/no-body.cpp`) use, to assert a non-zero exit code of a command. Otherwise, `llvm-lit` would complain and give a failure.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59924/new/

https://reviews.llvm.org/D59924