[PATCH] D60323: [clangd] Include compile command inference in fileStatus API

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 8 02:39:58 PDT 2019


hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clangd/GlobalCompilationDatabase.cpp:70
                                  /*Output=*/"");
+  Result.Heuristic = "default flags for unknown file";
+  return Result;
----------------
`default flags` seems not quite clear to me, maybe use `fallback compile command for unknown file`?


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60323/new/

https://reviews.llvm.org/D60323





More information about the cfe-commits mailing list